Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the inverse of decfa #1760

Merged
merged 2 commits into from Mar 12, 2019

Conversation

@arokem
Copy link
Member

commented Mar 11, 2019

Just for you, @frheault.

@jchoude
Copy link
Contributor

left a comment

Thanks for that @arokem. A few quick comments.

dipy/io/utils.py Outdated Show resolved Hide resolved
dipy/io/utils.py Outdated Show resolved Hide resolved
dipy/io/utils.py Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Copy link

commented Mar 12, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@e51eaca). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1760   +/-   ##
=========================================
  Coverage          ?   83.76%           
=========================================
  Files             ?      119           
  Lines             ?    14452           
  Branches          ?     2278           
=========================================
  Hits              ?    12106           
  Misses            ?     1823           
  Partials          ?      523
Impacted Files Coverage Δ
dipy/io/utils.py 66.66% <100%> (ø)
@jchoude

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

To me this is good to go. What's up with Travis acting up?

@arokem

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2019

It ran into both #1752 and #1747 in one run. Doesn't look like anything to do with this PR.

@jchoude

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Perfect. Let's go then 🚀

@jchoude jchoude merged commit 0dcec66 into nipy:master Mar 12, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.