Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF - add tracking workflow parameters #1766

Merged
merged 7 commits into from Apr 29, 2019

Conversation

@gabknight
Copy link
Contributor

commented Mar 13, 2019

  • dipy_track_local

    • added step_size option
    • change default algorithm from deterministicMaxDG to EuDX (#1787)
  • Update the DOC

this addresses #1758 .

@skoudoro

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

LGTM, Thank you @gabknight. Do you plan to address the second part of #1766 (Stopping_files...) on this PR or on a new one?

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@skoudoro I will add the second part as well.

Do you have any idea what is the error for the last commit?

@codecov-io

This comment has been minimized.

Copy link

commented Mar 14, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@193a8d9). Click here to learn what that means.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1766   +/-   ##
=========================================
  Coverage          ?   83.88%           
=========================================
  Files             ?      120           
  Lines             ?    14570           
  Branches          ?     2295           
=========================================
  Hits              ?    12222           
  Misses            ?     1824           
  Partials          ?      524
Impacted Files Coverage Δ
dipy/workflows/tracking.py 95.94% <71.42%> (ø)

@gabknight gabknight force-pushed the gabknight:NF_add_workflow_param branch from 6afa46c to f367d48 Mar 26, 2019

@gabknight gabknight changed the title [WIP] NF - add tracking workflow parameters NF - add tracking workflow parameters Mar 26, 2019

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

I just rebased. The PR is ready to be reviewed/merged.

@skoudoro
Copy link
Member

left a comment

Thank you for this @gabknight! Below some quick comments. Overall, it looks good to me. I just wonder whether you plan to update the Stopping_files management or we keep it for a new PR.

dipy/workflows/tracking.py Outdated Show resolved Hide resolved
dipy/workflows/tracking.py Show resolved Hide resolved
dipy/workflows/tracking.py Show resolved Hide resolved

@skoudoro skoudoro added this to the 1.0 milestone Apr 23, 2019

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Thanks @skoudoro.

This addresses #1758 and #1787.

Let's keep the Stopping_files enhancement for another PR (#1811)

@skoudoro skoudoro merged commit cd006c0 into nipy:master Apr 29, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@skoudoro

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thank you @gabknight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.