Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for different dtypes #1788

Merged
merged 4 commits into from Mar 20, 2019

Conversation

@arokem
Copy link
Member

commented Mar 16, 2019

This tests whether #1783 is still an issue, which I believe is not the case anymore. 🤷‍♂️

Samuel St-Jean and others added 3 commits Jan 18, 2016
@pep8speaks

This comment has been minimized.

Copy link

commented Mar 16, 2019

Hello @arokem, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2019-03-16 22:05:25 UTC
@codecov-io

This comment has been minimized.

Copy link

commented Mar 17, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@bfde017). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1788   +/-   ##
=========================================
  Coverage          ?   83.88%           
=========================================
  Files             ?      120           
  Lines             ?    14572           
  Branches          ?     2295           
=========================================
  Hits              ?    12224           
  Misses            ?     1824           
  Partials          ?      524
@skoudoro

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Thanks @arokem! Merging

@skoudoro skoudoro merged commit 01f872a into nipy:master Mar 20, 2019

4 checks passed

codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.