Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] stripping in workflow documentation #1796

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@skoudoro
Copy link
Member

commented Mar 27, 2019

this PR should fix @jchoude comment concerning the line break strips the space.
Reference: #1793

Before (look at positional args documentation):

image

After (look at positional args documentation):

image

@jchoude

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

LGTM! I'll wait until Travis finishes.
Thanks @skoudoro

@codecov-io

This comment has been minimized.

Copy link

commented Mar 28, 2019

Codecov Report

Merging #1796 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
- Coverage   83.88%   83.85%   -0.03%     
==========================================
  Files         120      120              
  Lines       14570    14570              
  Branches     2295     2295              
==========================================
- Hits        12222    12218       -4     
- Misses       1824     1827       +3     
- Partials      524      525       +1
Impacted Files Coverage Δ
dipy/workflows/base.py 78.8% <100%> (ø) ⬆️
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️

@jchoude jchoude merged commit a852ecd into nipy:master Mar 28, 2019

4 checks passed

codecov/patch 100% of diff hit (target 83.88%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +16.11% compared to 8565132
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-workflow-strip branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.