Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add a basic check on dipy_horizon #1814

Merged
merged 2 commits into from May 3, 2019

Conversation

@skoudoro
Copy link
Member

commented Apr 30, 2019

this PR should fix #1756.

@arokem

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Great! Is there any way we could test the app in different configurations? Even just smoke-testing would be useful to make sure we don't run into this kind of thing again.

@skoudoro skoudoro added this to the 1.0 milestone Apr 30, 2019

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

I agree. I think it should be a way to generate many argument combinations. I will look into it and create a new PR when I find something reasonable

@arokem

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Cool cool

@arokem arokem merged commit c719df1 into nipy:master May 3, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@skoudoro skoudoro deleted the skoudoro:fix-1756 branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.