Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated module dipy.segment.quickbundes #1827

Merged
merged 3 commits into from May 6, 2019

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented May 6, 2019

This PR removes the deprecated module dipy.segment.quickbundles in favor of dipy.segment.clustering.

from dipy.segment.quickbundles import QuickBundles


def test_qbundles():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an equivalent of this test somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, More complete on this file: test_quickbundles.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Lets' go!

@arokem arokem merged commit 438536a into dipy:master May 6, 2019
@skoudoro skoudoro deleted the remove-qb-old branch May 6, 2019 16:11
jhlegarreta added a commit to jhlegarreta/tractometer that referenced this pull request Oct 16, 2019
Fix `QuickBundles` instantiation.

`dipy.segment.quickbundles. QuickBundles` was deprecated in favor of
``dipy.segment.clustering.QuickBundles` by DIPY commit
dipy/dipy@a809bb5

which as merged in DIPY PR
dipy/dipy#568

And it was removed in DIPY PR
dipy/dipy#1827
jhlegarreta added a commit to jhlegarreta/tractometer that referenced this pull request Oct 16, 2019
Fix `QuickBundles` instantiation.

`dipy.segment.quickbundles. QuickBundles` was deprecated in favor of
``dipy.segment.clustering.QuickBundles` by DIPY commit
dipy/dipy@a809bb5

which as merged in DIPY 0.9.2 PR
dipy/dipy#568

And it was removed in DIPY 1.0.0 PR
dipy/dipy#1827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants