Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete six module #1830

Merged
merged 8 commits into from May 12, 2019

Conversation

@skoudoro
Copy link
Member

commented May 10, 2019

Deleting six module. This module was used to maintain compatibility with Python 2. Not needed anymore

@skoudoro skoudoro added this to the 1.0 milestone May 10, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #1830 into master will increase coverage by 0.69%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   83.59%   84.28%   +0.69%     
==========================================
  Files         118      117       -1     
  Lines       14486    14222     -264     
  Branches     2283     2245      -38     
==========================================
- Hits        12109    11987     -122     
+ Misses       1851     1718     -133     
+ Partials      526      517       -9
Impacted Files Coverage Δ
dipy/reconst/cross_validation.py 95.83% <ø> (-0.09%) ⬇️
dipy/reconst/dti.py 96.49% <ø> (-0.01%) ⬇️
dipy/tracking/life.py 97.77% <ø> (-0.02%) ⬇️
dipy/reconst/dki.py 96.81% <ø> (-0.01%) ⬇️
dipy/reconst/csdeconv.py 89.9% <ø> (-0.04%) ⬇️
dipy/utils/_importlib.py 13.04% <0%> (ø) ⬆️
dipy/workflows/multi_io.py 72.26% <0%> (-0.21%) ⬇️
dipy/io/gradients.py 90.24% <0%> (-0.24%) ⬇️
dipy/workflows/flow_runner.py 100% <100%> (ø) ⬆️
dipy/direction/peaks.py 83.49% <100%> (-0.08%) ⬇️
... and 12 more
@arokem

This comment has been minimized.

Copy link
Member

commented May 10, 2019

I find it fascinating that CodeCov thinks that this resulted in decreased coverage. At any rate, this LGTM, and unless someone objects strongly, I can merge this in a day or two.

@arokem arokem merged commit a232391 into nipy:master May 12, 2019

4 of 5 checks passed

codecov/patch 82.14% of diff hit (target 83.59%)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/project 84.28% (+0.69%) compared to 0431080
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:delete-six branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.