Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] IVIM fixes #1839

Closed
wants to merge 1 commit into from

Conversation

@ShreyasFadnavis
Copy link
Member

commented May 20, 2019

Making amendments for #1817 and #1828

  • Add documentation for bounding parameters.
@@ -286,7 +286,7 @@ def __init__(self, gtab, split_b_D=400.0, split_b_S0=200., bounds=None,
e_s += "bounds. Please update to Scipy 0.17 to use bounds"
raise ValueError(e_s)
elif self.bounds is None:
self.bounds = ((0., 0., 0., 0.), (np.inf, .3, 1., 1.))
self.bounds = ((0., 0., 0., 0.), (np.inf, .3, 0.2, 1.))

This comment has been minimized.

Copy link
@arokem

arokem May 22, 2019

Member

Could you please define these bounds as module-level global variables, so that we can reuse them in https://github.com/nipy/dipy/blob/master/dipy/reconst/ivim.py#L661 and other places? Also, we need to change the documentation (e.g., https://github.com/nipy/dipy/blob/master/dipy/reconst/ivim.py#L216) accordingly.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Hi @ShreyasFadnavis, What is the status of this PR? Any chances to address @arokem request and rebase this PR? Thank you!

@ShreyasFadnavis

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

Created a new PR. Closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.