Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin scipy version for bots that need statsmodels. #1855

Merged
merged 2 commits into from Jun 18, 2019

Conversation

@arokem
Copy link
Member

commented Jun 12, 2019

This is due to breaking changes in the scipy API that will be fixed on an eventual release of statsmodels. For now, let's pin this and unpin when a new release of scipy comes along.

Should help deal with this breakage: https://travis-ci.org/nipy/dipy/jobs/542426220#L6092

arokem added 2 commits Jun 12, 2019
Pin scipy version for bots that need statsmodels.
This is due to breaking changes in the scipy API that will be fixed on
an eventual release of statsmodels. For now, let's pin this and unpin
when a new release of scipy comes along.
@codecov-io

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@703cd83). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1855   +/-   ##
=========================================
  Coverage          ?   84.31%           
=========================================
  Files             ?      117           
  Lines             ?    14234           
  Branches          ?     2251           
=========================================
  Hits              ?    12001           
  Misses            ?     1716           
  Partials          ?      517
@arokem

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

It looks like the bots are happy, but is there a more elegant way to implement this?

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

No Idea yet but I propose to merge this and we can create an issue to improve our Travis design.

What do you think?

@arokem

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

Sounds good. I also want to experiment a bit with CircleCI, so I can do that on a separate PR. But yes: feel free to merge this one.

@skoudoro skoudoro merged commit b716c3c into nipy:master Jun 18, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Thank you @arokem for this!

This was referenced Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.