Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add binary tissue classifier option for tracking workflow #1875

Conversation

@jhlegarreta
Copy link
Contributor

commented Jun 26, 2019

Add binary tissue classifier option for tracking workflow.

Fixes #1811.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

@gabknight reviews are welcome.

@codecov-io

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@deedcdf). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1875   +/-   ##
=========================================
  Coverage          ?   84.37%           
=========================================
  Files             ?      118           
  Lines             ?    14413           
  Branches          ?     2274           
=========================================
  Hits              ?    12161           
  Misses            ?     1729           
  Partials          ?      523
Impacted Files Coverage Δ
dipy/workflows/tracking.py 96.42% <100%> (ø)
@codecov-io

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a101652). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1875   +/-   ##
=========================================
  Coverage          ?   84.91%           
=========================================
  Files             ?      118           
  Lines             ?    14298           
  Branches          ?     2248           
=========================================
  Hits              ?    12141           
  Misses            ?     1645           
  Partials          ?      512
Impacted Files Coverage Δ
dipy/workflows/tracking.py 96.42% <100%> (ø)
dipy/workflows/tracking.py Outdated Show resolved Hide resolved
@gabknight

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

See my 2 minor comments above. Otherwise, this LGTM.

Thanks for doing this PR @jhlegarreta

jhlegarreta added 3 commits Jun 26, 2019
ENH: Add binary tissue classifier option for tracking workflow
Add binary tissue classifier option for tracking workflow.

Fixes #1811.
DOC: Improve `use_binary_mask` parameter documentation
Improve `use_binary_mask` parameter documentation.
ENH: Use a binary mask explicitly for tracking workflow testing
Use a binary mask explicitly for tracking workflow testing.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:AddTrackingWorkflowBinaryTissueClassifierOption branch from 2d3e39c to b3a4b27 Jul 2, 2019

@gabknight

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Thanks @jhlegarreta

Let see if Travis has something to say. Otherwise, this seems ready to be merged.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

192fb69 rebased on master.

@gabknight gabknight merged commit 33df2b5 into nipy:master Jul 5, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jhlegarreta jhlegarreta deleted the jhlegarreta:AddTrackingWorkflowBinaryTissueClassifierOption branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.