Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up: Remove all SCIPY_LESS_0.x.x #1877

Merged
merged 6 commits into from Jul 1, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 1, 2019

This PR should fix #1863. It removes all SCIPY_LESS_0.x.x

@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #1877 into master will increase coverage by 0.44%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
+ Coverage   84.37%   84.81%   +0.44%     
==========================================
  Files         118      118              
  Lines       14411    14319      -92     
  Branches     2273     2252      -21     
==========================================
- Hits        12159    12145      -14     
+ Misses       1729     1660      -69     
+ Partials      523      514       -9
Impacted Files Coverage Δ
dipy/align/imaffine.py 92.05% <100%> (+0.47%) ⬆️
dipy/core/optimize.py 97.61% <100%> (+32.46%) ⬆️
dipy/reconst/ivim.py 96.17% <92%> (+12.17%) ⬆️
@arokem

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

That's what I like to see:
Screen Shot 2019-07-01 at 8 55 31 AM

@arokem arokem merged commit 84291cf into nipy:master Jul 1, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 93.93% of diff hit (target 84.37%)
Details
codecov/project 84.81% (+0.44%) compared to d1f0f34
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:clean-core-optimize branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.