Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up: Remove NUMPY_LESS_0.8.x #1878

Merged
merged 2 commits into from Jul 1, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 1, 2019

As a follow up of #1877, this PR remove NUMPY_LESS_0.8.x and eigh function

skoudoro added 2 commits Jul 1, 2019

@skoudoro skoudoro changed the title Remove NUMPY_LESS_0.8.x Clean up: Remove NUMPY_LESS_0.8.x Jul 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #1878 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1878      +/-   ##
==========================================
+ Coverage   84.37%   84.46%   +0.09%     
==========================================
  Files         118      118              
  Lines       14411    14388      -23     
  Branches     2273     2268       -5     
==========================================
- Hits        12159    12153       -6     
+ Misses       1729     1714      -15     
+ Partials      523      521       -2
Impacted Files Coverage Δ
dipy/utils/arrfuncs.py 100% <100%> (+43.58%) ⬆️
dipy/reconst/dti.py 96.49% <100%> (ø) ⬆️
@arokem

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

Good stuff.

@arokem arokem merged commit a101652 into nipy:master Jul 1, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 84.37%)
Details
codecov/project 84.46% (+0.09%) compared to d1f0f34
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:remove-numpy-less branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.