Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC - explicitly run the streamline generators before saving the trk #1879

Merged
merged 2 commits into from Jul 8, 2019

Conversation

@gabknight
Copy link
Contributor

commented Jul 2, 2019

This addresses #1779 and clarifies the examples.

Any idea on the root of the problem in #1779 ?

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Nice! Thank you @gabknight!

Any idea on the root of the problem in #1779 ?

No idea at the moment, I will look deeper into it this week.

@pep8speaks

This comment has been minimized.

Copy link

commented Jul 2, 2019

Hello @gabknight, Thank you for updating !

Line 69:1: E402 module level import not at top of file

@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a101652). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1879   +/-   ##
=========================================
  Coverage          ?   84.91%           
=========================================
  Files             ?      118           
  Lines             ?    14296           
  Branches          ?     2247           
=========================================
  Hits              ?    12139           
  Misses            ?     1645           
  Partials          ?      512
@arokem

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

An idea: how about if save_trk always tried to call Streamlines on its input? That way, we could pass it a generator and it would do the right thing.

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@arokem save_trk accept generators, normally without issues (I cannot reproduce the problem in #1779). It is actually a good idea to provide a generator as the streamlines will be generated as they are saved, limiting memory issue for a high number of seeds.

There seems the be corner cases where this fails though.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Agree with @gabknight. Thank you for this update! merging

@skoudoro skoudoro merged commit c8176ac into nipy:master Jul 8, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.