Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC - RF tracking examples #1881

Merged
merged 15 commits into from Jul 22, 2019

Conversation

@gabknight
Copy link
Contributor

commented Jul 2, 2019

This PR will address #1432.

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Waiting on #1879 and #1882 before moving on with other points of #1432.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #1881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1881   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         119      119           
  Lines       14298    14298           
  Branches     2243     2243           
=======================================
  Hits        12215    12215           
  Misses       1575     1575           
  Partials      508      508
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Both has been merged, you can continue your PR 😄

@gabknight gabknight force-pushed the gabknight:RF_tracking_examples branch from b4dcd26 to 1b59f49 Jul 9, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Jul 9, 2019

Hello @gabknight, Thank you for updating !

Line 23:1: E402 module level import not at top of file
Line 24:1: E402 module level import not at top of file
Line 25:1: E402 module level import not at top of file

Line 32:1: E402 module level import not at top of file
Line 35:1: E402 module level import not at top of file

Line 75:1: E402 module level import not at top of file
Line 112:1: E402 module level import not at top of file
Line 169:1: E402 module level import not at top of file

Line 39:1: E402 module level import not at top of file

Line 30:1: E402 module level import not at top of file

Line 112:1: E402 module level import not at top of file

Line 42:1: E402 module level import not at top of file

Comment last updated at 2019-07-21 12:39:28 UTC

@gabknight gabknight changed the title WIP - RF tracking examples DOC - RF tracking examples Jul 9, 2019

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

OK. This addresses #1432.

@skoudoro How can I build the html to test the overall display and links. make html fails on my machine with python 3.7

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

when you are in the docs folder, make -C . html should work. Let me know if it is still failing

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

OK. thx it works, but I add to fix this unicode error.

dfile.write('.. AUTO-GENERATED FILE -- DO NOT EDIT!\n\n'.encode('utf-8'))
TypeError: write() argument 1 must be unicode, not str

# fix ==>
dfile.write(u'.. AUTO-GENERATED FILE -- DO NOT EDIT!\n\n')
@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

OK. Built examples are looking good.

  • uniformized examples
  • remove redundant pieces
  • add figures
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

ok, Thank you for this! I will try to build the examples today and merge this PR after that.

@skoudoro
Copy link
Member

left a comment

Hi @gabknight, it looks very good. Everything is running as expected and the doc looks nice.

I just made a few comments below. Can you rebase too?
Thanks!

doc/examples/valid_examples.txt Outdated Show resolved Hide resolved
doc/examples_index.rst Show resolved Hide resolved
doc/examples/tracking_bootstrap_peaks.py Show resolved Hide resolved

@gabknight gabknight force-pushed the gabknight:RF_tracking_examples branch from 42ca734 to 96e201f Jul 21, 2019

gabknight added 2 commits Jul 21, 2019
@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

@skoudoro thanks for the feedback.

The PR is ready on my side. Let me know if you see other things to change.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Great! looks good, thank you @gabknight! I will wait for Travis even if it doesn't run the examples and then go ahead and merge it.

@skoudoro skoudoro merged commit 1a697bc into nipy:master Jul 22, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing d80d01d...785b07c
Details
codecov/project 85.43% remains the same compared to d80d01d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Thank you for this example refactoring @gabknight ! Merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.