Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - remove single pts streamline #1885

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@gabknight
Copy link
Contributor

commented Jul 5, 2019

Since #1666, it was possible to return "valid" streamlines with a single point. This could happen in corner cases with a sequence of voxels: gm - wm - gm, wherein a single tracking step the tracking stops in the gm on both sides, resulting in a correctly ending streamline of a single point.

This PR fixes this.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@70cbf33). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1885   +/-   ##
=========================================
  Coverage          ?   85.39%           
=========================================
  Files             ?      118           
  Lines             ?    14245           
  Branches          ?     2238           
=========================================
  Hits              ?    12165           
  Misses            ?     1574           
  Partials          ?      506
Impacted Files Coverage Δ
dipy/tracking/local/localtracking.py 95.91% <100%> (ø)
@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2019

@skoudoro Do you know what is failing here?

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

Unrelated to this PR. Something to do with byte ordering on Windows in the bowels of some Cython code...

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 6, 2019

In General, we should start to track cython and python warning on Travis. I think it will helps. I will create an issue for that

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

Can you rebase this one too to make Appveyor happy? This error should be fixed.

This PR is ready to be merged, Does someone has a suggestion? it will be good to merge this in the middle of this coming week

@gabknight gabknight force-pushed the gabknight:BF_single_pts_streamline branch from 7106017 to 0fc3f82 Jul 22, 2019

@gabknight gabknight force-pushed the gabknight:BF_single_pts_streamline branch from 0fc3f82 to c5cab8b Jul 25, 2019

@skoudoro skoudoro added this to the 1.0 milestone Jul 25, 2019

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

thank @gabknight for this bug fix, merging

@skoudoro skoudoro merged commit 239c699 into nipy:master Jul 25, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.