Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC - updated streamline_tools example with the LocalTracking Framework #1887

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@gabknight
Copy link
Contributor

commented Jul 5, 2019

Changed the call from EuDX to LocalTracking. EuDX is still the algorithm use here, but in the new framework.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4342302). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1887   +/-   ##
=========================================
  Coverage          ?   84.91%           
=========================================
  Files             ?      118           
  Lines             ?    14296           
  Branches          ?     2247           
=========================================
  Hits              ?    12139           
  Misses            ?     1645           
  Partials          ?      512
@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thanks @gabknight. Should we keep the Eudx class or more generally eudx.py (old framework)?

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@skoudoro, no, no need to keep it as it is essentially the same as LocalTracking with PeaksAndMetricDG. I want to refactor this: remove eudx.py, rename PeaksAndMetricDG to EudxDG, and move the eudx tests.

This will be in the another PR addressing #1501.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

ok, sounds good! Do you need help? Today, I can do this part of removing eudx.py and renaming PeaksAndMetricsDG

@gabknight

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

@skoudoro sure give it a go if you have time. The tricky part will adjust the tests. It will be very good to do it, as the current PeakAndMetricDG is not properly tested.
If you don't, I will do it at the time RF the tracking.local package. I'll be away from now until 19.07, I'm not sure I can make it for the next release.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

I just run the documentation and this example, everything looks good. merging

Thanks @gabknight!

@skoudoro skoudoro merged commit df3b6ef into nipy:master Jul 19, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.