Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SingleTensor by single_tensor #1898

Merged
merged 5 commits into from Jul 15, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 12, 2019

This PR removes the backward compatibilities with SingleTensor, MultiTensor and StickAndBall`.

dipy.sims.voxel.SingleTensor has been replaced by dipy.sims.voxel.single_tensor
dipy.sims.voxel.MultiTensor has been replaced by dipy.sims.voxel.multi_tensor
dipy.sims.voxel.SticksAndBall has been replaced by dipy.sims.voxel.sticks_and_ball

This should fix #844

@codecov-io

This comment has been minimized.

Copy link

commented Jul 12, 2019

Codecov Report

Merging #1898 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
- Coverage   85.31%   85.31%   -0.01%     
==========================================
  Files         118      118              
  Lines       14221    14218       -3     
  Branches     2236     2236              
==========================================
- Hits        12133    12130       -3     
  Misses       1577     1577              
  Partials      511      511
Impacted Files Coverage Δ
dipy/sims/voxel.py 90.45% <ø> (-0.13%) ⬇️
dipy/reconst/forecast.py 90.15% <ø> (ø) ⬆️
dipy/reconst/mapmri.py 90.33% <ø> (ø) ⬆️
dipy/reconst/shore.py 85.15% <ø> (ø) ⬆️
dipy/sims/phantom.py 65.16% <100%> (ø) ⬆️
dipy/data/__init__.py 81.45% <100%> (ø) ⬆️
@Borda
Borda approved these changes Jul 13, 2019
Copy link
Contributor

left a comment

looks good to me :)

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Looks good to me too. I'll go ahead and merge

@arokem arokem merged commit c83f279 into nipy:master Jul 15, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 100% of diff hit (target 85.31%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +14.68% compared to 271fc6f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:single-tensor branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.