Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Byte ordering error on Python 3.5 #1899

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 12, 2019

I believe this PR should fix #1642 and more specifically, the following error we have seen intermittently:

ValueError: cannot expose native-only dtype 'g' in non-native byte order '<' via buffer interface

Let's see

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Big if true

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2019

Hi @arokem, it seems to go well 🤞 , but I think we should try to rerun multiple times python3.5 builds. Can you do it for Appveyor when it is done? It seems that I can't...

@codecov-io

This comment has been minimized.

Copy link

commented Jul 13, 2019

Codecov Report

Merging #1899 into master will decrease coverage by 1.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
- Coverage   85.31%   83.83%   -1.49%     
==========================================
  Files         118      118              
  Lines       14221    14221              
  Branches     2236     2236              
==========================================
- Hits        12133    11922     -211     
- Misses       1577     1787     +210     
- Partials      511      512       +1
Impacted Files Coverage Δ
dipy/viz/panel.py 7.04% <0%> (-76.06%) ⬇️
dipy/workflows/viz.py 25% <0%> (-65.63%) ⬇️
dipy/viz/app.py 5.11% <0%> (-47.25%) ⬇️
dipy/viz/__init__.py 50% <0%> (-40%) ⬇️
dipy/testing/decorators.py 77.41% <0%> (-16.13%) ⬇️
dipy/utils/optpkg.py 69.56% <0%> (-4.35%) ⬇️
dipy/io/vtk.py 10.41% <0%> (-4.17%) ⬇️
dipy/workflows/stats.py 89.6% <0%> (-2.41%) ⬇️
dipy/stats/analysis.py 74.3% <0%> (-0.7%) ⬇️
@arokem

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Currently rebuilding on Appveyor. Two things:

  1. I am not sure why you don't have permissions to kick off a rebuild on appveyor. You can always trigger a rebuild by doing a git commit --amend, changing your last commit message and then force pushing.

  2. This change looks good whether or not it fixes that particular issue, so I am +1 for merging it either way :-)

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

OK. Since no one complained here, I am going to go ahead and merge.

@arokem arokem merged commit 720090c into nipy:master Jul 15, 2019

4 of 5 checks passed

codecov/project 83.83% (-1.49%) compared to 271fc6f
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected when comparing 271fc6f...ad34d11
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-byte-order branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.