Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some tests on big endian architecture (like s390x) #1903

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 16, 2019

this PR should resolve #1587.

@arokem and @yarikoptic, Can you have a look?

I do not know how we can add a test. Any idea?

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

This looks good to me.

Anyone have access to a big 🔚-ian machine?

@codecov-io

This comment has been minimized.

Copy link

commented Jul 17, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@17b68f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1903   +/-   ##
========================================
  Coverage          ?   85.4%           
========================================
  Files             ?     119           
  Lines             ?   14309           
  Branches          ?    2249           
========================================
  Hits              ?   12221           
  Misses            ?    1577           
  Partials          ?     511

@skoudoro skoudoro added this to the 1.0 milestone Jul 25, 2019

@skoudoro

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

It seems that no one has access to this kind of machine. What should we do @arokem with this PR?

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

This looks safe to merge because it only skips a few tests on big endian. So merging...

@Garyfallidis Garyfallidis merged commit 4dccfe5 into nipy:master Jul 30, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:skip-big-endian branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.