Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove deprecated SH bases #1905

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@jhlegarreta
Copy link
Contributor

commented Jul 17, 2019

Remove deprecated SH bases.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@arokem @skoudoro as discussed in the dev meeting this morning. I guess we are aware of the fact that dependent software developers will need to adapt to the change.

@arokem

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Might be worth documenting this one in https://github.com/nipy/dipy/blob/master/doc/api_changes.rst.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Thanks for the review @arokem. Done in 68640a3.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Hi @jhlegarreta,

Can you rebase? I think you forgot to remove some DeprecationWarning test too. Thank you for this.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:RemoveDeprecatedSHBases branch from 68640a3 to 418c6f3 Jul 17, 2019

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@skoudoro I'd dare to say that I had removed them.

Rebased on master and push-forced.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

it seems you forgot the one here and here, this is why Travis is failing.

jhlegarreta added 2 commits Jul 17, 2019
ENH: Remove deprecated SH bases
Remove deprecated SH bases.
DOC: Document the SH bases API change
Document the SH bases API change.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:RemoveDeprecatedSHBases branch from 418c6f3 to 2f91b06 Jul 17, 2019

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@skoudoro my bad. Sorry for the oversight. 68e5dd7 should address all cases. Rebased and push forced.

@jhlegarreta

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Just one particular Travis build is failing. I guess we are experiencing this in other PRs.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

it was a weird error, I restarted this matrix to make sure that's is reproducible. I do not see it on other PR

@skoudoro

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Thank you @jhlegarreta, merging!

@skoudoro skoudoro merged commit d80d01d into nipy:master Jul 18, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jhlegarreta jhlegarreta deleted the jhlegarreta:RemoveDeprecatedSHBases branch Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.