Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated parameter voxel_size #1912

Merged
merged 4 commits into from Jul 24, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 18, 2019

Since voxel_size was deprecated since a long time, this parameter has been removed from the following function:
dipy.tracking.utils.connectivity_matrix
dipy.tracking.utils.density_map
dipy.tracking.utils.streamline_mapping
dipy.tracking._util._mapping_to_voxel

@codecov-io

This comment has been minimized.

Copy link

commented Jul 19, 2019

Codecov Report

Merging #1912 into master will decrease coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   85.43%   85.42%   -0.01%     
==========================================
  Files         119      119              
  Lines       14298    14290       -8     
  Branches     2243     2242       -1     
==========================================
- Hits        12215    12207       -8     
  Misses       1575     1575              
  Partials      508      508
Impacted Files Coverage Δ
dipy/tracking/utils.py 88.95% <100%> (ø) ⬆️
dipy/tracking/_utils.py 88.23% <83.33%> (-3.77%) ⬇️
@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Our great cleaning up continues! Dipy 1.0 for the win!

@Garyfallidis Garyfallidis merged commit ff5aa84 into nipy:master Jul 24, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 92.3% of diff hit (target 85.43%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.87% compared to d80d01d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:remove-deprecated-voxel-size branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.