Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Spherical deconvolution model CANNOT be constructed without specifying a response #1916
I've created this PR basically to address issue #283.
After analysing the issue, I've decided that the best solution is to remove the response=None option. If one wants to use a predefined response function, it can just defined it on its own risk by calling:
Using an None option is not ideal also because it does not allows the adjustment of S0. At the current version of the CSD implementation, data is normalised based on this inputed S0 estimate, so having it properly estimated might be crucial for the estimation of the fODF shape.
After revising the CSD example, I've noticed that it might be hard to ready for non diffusion MRI experts. For instance, it might not be clear that the time consuming response function calibration procedure is optional. To make the example easier to read, I've added some sub-headings. Please let me know your comments and suggestions on this issue.
@@ Coverage Diff @@ ## master #1916 +/- ## ========================================== - Coverage 85.43% 85.42% -0.01% ========================================== Files 119 119 Lines 14298 14296 -2 Branches 2243 2242 -1 ========================================== - Hits 12215 12213 -2 Misses 1575 1575 Partials 508 508