Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] removing minmax_norm parameter from peak_direction #1923

Merged
merged 3 commits into from Jul 26, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 26, 2019

The goal of this PR is to fix #389. I use the opportunity to fix one test not related

@@ -162,7 +162,7 @@ def test_fit_data():
gtab = grad.gradient_table(fbval, fbvec)
ni_data = nib.load(fdata)
data = ni_data.get_data()
tensor_streamlines, _ = load_tractogram(fstreamlines)

This comment has been minimized.

Copy link
@gabknight

gabknight Jul 26, 2019

Contributor

Could you also remove the import for load_tractogram

This comment has been minimized.

Copy link
@skoudoro

skoudoro Jul 26, 2019

Author Member

Indeed, Thank you! Done in db26854

@codecov-io

This comment has been minimized.

Copy link

commented Jul 26, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@adfc116). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1923   +/-   ##
=========================================
  Coverage          ?   84.56%           
=========================================
  Files             ?      118           
  Lines             ?    14683           
  Branches          ?     2328           
=========================================
  Hits              ?    12417           
  Misses            ?     1722           
  Partials          ?      544
Impacted Files Coverage Δ
dipy/direction/peaks.py 83.49% <ø> (ø)
@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

Fixes!! Yep! :)

@Garyfallidis Garyfallidis merged commit 2ff8ace into nipy:master Jul 26, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@skoudoro skoudoro deleted the skoudoro:fix-389 branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.