Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dipy.external and dipy.fixes packages #1935

Merged
merged 3 commits into from Jul 30, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 29, 2019

Still cleaning... Removing dipy.external and dipy.fixes packages.

@codecov-io

This comment has been minimized.

Copy link

commented Jul 30, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@3f61e9b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1935   +/-   ##
=========================================
  Coverage          ?   84.63%           
=========================================
  Files             ?      118           
  Lines             ?    14678           
  Branches          ?     2326           
=========================================
  Hits              ?    12422           
  Misses            ?     1713           
  Partials          ?      543
Impacted Files Coverage Δ
dipy/__init__.py 71.42% <ø> (ø)
dipy/core/gradients.py 91.03% <100%> (ø)
@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

More cleaning to accommodate DIPY 1.0! Great!

@Garyfallidis Garyfallidis merged commit 4de2d70 into nipy:master Jul 30, 2019

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:remove-external branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.