Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dipy.io.trackvis #1942

Merged
merged 6 commits into from Aug 1, 2019

Conversation

@skoudoro
Copy link
Member

commented Jul 30, 2019

The module dipy.io.trackvis was deprecated since the 0.14.0 release. This PR remove this module and update all the necessary files

@pep8speaks

This comment has been minimized.

Copy link

commented Jul 30, 2019

Hello @skoudoro, Thank you for updating !

Line 106:1: E402 module level import not at top of file
Line 107:1: E402 module level import not at top of file
Line 216:1: E402 module level import not at top of file
Line 217:1: E402 module level import not at top of file

Comment last updated at 2019-08-01 15:04:32 UTC
skoudoro added 2 commits Jul 31, 2019

streamlines = [i[0] for i in streams]
streamlines = Streamlines(fornix)

This comment has been minimized.

Copy link
@Garyfallidis

Garyfallidis Aug 1, 2019

Member

Shouldn't this be streamlines = fornix?

This comment has been minimized.

Copy link
@frheault

frheault Aug 1, 2019

Contributor

Or the load_tractogram().streamlines directly

This comment has been minimized.

Copy link
@skoudoro

skoudoro Aug 1, 2019

Author Member

This is a tutorial, I just wanted to be explicit for the user. So now, it is:
streamlines = fornix.streamlines

fornix = load_tractogram(fname, 'same',
bbox_valid_check=False).streamlines

streamlines = Streamlines(fornix)

This comment has been minimized.

Copy link
@Garyfallidis

Garyfallidis Aug 1, 2019

Member

Shouldn't this be streamlines=fornix?

fornix = load_tractogram(fname, 'same',
bbox_valid_check=False).streamlines

streamlines = Streamlines(fornix)

This comment has been minimized.

Copy link
@Garyfallidis

Garyfallidis Aug 1, 2019

Member

see below

@codecov

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4de2d70). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1942   +/-   ##
=========================================
  Coverage          ?   82.95%           
=========================================
  Files             ?      117           
  Lines             ?    14620           
  Branches          ?     2321           
=========================================
  Hits              ?    12128           
  Misses            ?     1950           
  Partials          ?      542
Impacted Files Coverage Δ
dipy/segment/clustering.py 94.63% <ø> (ø)
dipy/data/fetcher.py 34.92% <0%> (ø)
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 1, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4de2d70). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1942   +/-   ##
=========================================
  Coverage          ?   82.95%           
=========================================
  Files             ?      117           
  Lines             ?    14620           
  Branches          ?     2321           
=========================================
  Hits              ?    12128           
  Misses            ?     1950           
  Partials          ?      542
Impacted Files Coverage Δ
dipy/segment/clustering.py 94.63% <ø> (ø)
dipy/data/fetcher.py 34.92% <0%> (ø)

@Garyfallidis Garyfallidis merged commit dcbf84f into nipy:master Aug 1, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:remove-trackvis branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.