Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase affine consistency in dipy.tracking.life and dipy.stats.analysis #1943

Merged
merged 4 commits into from Jul 31, 2019

Conversation

@frheault
Copy link
Contributor

commented Jul 31, 2019

To increase consistency within Dipy and increase cautious behaviors when coding the affine is now required when it was previously optional.
Older/unused functions that had complex behavior related to spatial transform and trackvis file format were deleted to prevent confusion.
Docstring is now uniform when describing the affine.

Tests were executed and examples tested.

@skoudoro skoudoro added this to the 1.0 milestone Jul 31, 2019

@skoudoro
Copy link
Member

left a comment

Overall, it looks good. I just need to run the example. I just have a small comment below. Thank you @frheault!

@@ -261,7 +262,7 @@ def streamline_signal(self, streamline):
return sig_out


def voxel2streamline(streamline, transformed=False, affine=None,
def voxel2streamline(streamline, affine, transformed=False,

This comment has been minimized.

Copy link
@skoudoro

skoudoro Jul 31, 2019

Member

Here, you forgot to remove transformed=False parameter

@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@4de2d70). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1943   +/-   ##
=========================================
  Coverage          ?   84.63%           
=========================================
  Files             ?      119           
  Lines             ?    14701           
  Branches          ?     2330           
=========================================
  Hits              ?    12442           
  Misses            ?     1712           
  Partials          ?      547
Impacted Files Coverage Δ
dipy/tracking/life.py 98.25% <100%> (ø)
dipy/stats/analysis.py 75% <100%> (ø)

@Garyfallidis Garyfallidis merged commit 637e5e7 into nipy:master Jul 31, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
@Garyfallidis

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.