Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty tractogram loading saving #1946

Merged
merged 6 commits into from Aug 2, 2019

Conversation

@frheault
Copy link
Contributor

commented Aug 1, 2019

As of right now loading and saving empty tractogram is crashing because of the bbox in voxel space being checked.

Addition of a simple condition in the verification.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Thank you @frheault, Can you add a small test for this? Thank you

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 1, 2019

Hello @frheault, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2019-08-01 20:47:31 UTC
@frheault

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@skoudoro I added the tests. The is_bbox_in_vox_valid check is technically done in the init, so everything is covered.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Thank you, waiting for Travis

@skoudoro skoudoro merged commit 94f2f9a into nipy:master Aug 2, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.