New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Windows test fixes #309

Merged
merged 6 commits into from Jan 11, 2014

Conversation

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Jan 10, 2014

FIxes from Ariel and I for test failures on gh-306.

Refactor script tests to allow paths with spaces.
Reduce precision required for one test
Use temporary directory context manager to allow windows to delete temporary files after test

matthew-brett and others added some commits Jan 6, 2014

RF: refactor dpy io tests to fix windows error
Try to fix windows access error by using InTemporaryDirectory rather
than a temporary file.
TST: Reduce the required precision here.
So that WIN32 can rejoin civilized society.
Merge pull request #1 from arokem/mbrett-windows-test-fixes
TST: Reduce the required precision for test.
RF: use sequences for run_command script tester
`run_command` was using strings rather than sequences passing in the
``Popen`` constructor.  This blows up when there are space in the passed
paths.  Use the sequence command definition instead.
RF: put pwd on path running tests from dipy dir
Some of the script tests change directory before running the scripts.
These will fail if the dipy we picked up is in the current working
directory (running from the dipy root directory). Check for this case
and put the directory on the path before running the scripts.
BF: ensure ravel_multi_index has good working type
Indices could overflow if input type of index array was not large
enough to hold large indices.
@@ -98,25 +147,21 @@ def assert_image_shape_affine(filename, shape, affine):
nt.assert_array_almost_equal(image.get_affine(), affine)
def test_dipy_fit_tensor():
def test_dipy_fit_tensor_again():

This comment has been minimized.

@arokem

This comment has been minimized.

@matthew-brett

matthew-brett Jan 11, 2014

Member

The test function had the same name as another test function further up the file.

This comment has been minimized.

@arokem

arokem Jan 11, 2014

Member

Got it. Makes sense. OTOH, it would be nice if they had names that told you
what is being tested. Maybe that's too much to ask in this case.

On Fri, Jan 10, 2014 at 4:19 PM, Matthew Brett notifications@github.comwrote:

In dipy/tests/test_scripts.py:

@@ -98,25 +147,21 @@ def assert_image_shape_affine(filename, shape, affine):
nt.assert_array_almost_equal(image.get_affine(), affine)

-def test_dipy_fit_tensor():
+def test_dipy_fit_tensor_again():

The test function had the same name as another test function further up
the file.


Reply to this email directly or view it on GitHubhttps://github.com//pull/309/files#r8807114
.

arokem added a commit that referenced this pull request Jan 11, 2014

@arokem arokem merged commit 471a72d into nipy:master Jan 11, 2014

1 check passed

default The Travis CI build passed
Details
@arokem

This comment has been minimized.

Member

arokem commented Jan 11, 2014

Was this the last blocker to tagging 0.7.1? @Garyfallidis? Do you want to pull the trigger on that?

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Jan 11, 2014

Sorry to be slow - but let me fix the release checks first... I hope I'll have time tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment