New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: more fixes for windows script tests #316

Merged
merged 2 commits into from Jan 15, 2014

Conversation

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Jan 15, 2014

We got more windows script test failures on the buildbots.

This turned out to be because I had changed the subprocess.Popen command to use
shell=False; if this is the case then windows needs the correct extension for
the executable. Add the '.bat' file extension for the executables on Windows.

Also, quote the Python executable path in case this path has spaces in it.

matthew-brett added some commits Jan 15, 2014

BF: quote python executable for windows scripts
Python executable can be in a path with spaces.  Quote the discovered python
executable just in case.
BF: add .bat to windows script names
Windows scripts need executable name, or shell=True.  Add .bat to name.

arokem added a commit that referenced this pull request Jan 15, 2014

Merge pull request #316 from matthew-brett/windows-script-fixes-2
MRG: more fixes for windows script tests

@arokem arokem merged commit 67c323f into nipy:master Jan 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment