New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shore pdf grid speed improvement #323

Merged
merged 2 commits into from Feb 10, 2014

Conversation

Projects
None yet
4 participants
@demianw
Contributor

demianw commented Feb 7, 2014

To modifications on the shore fit object:

  1. Improved the speed of the pdf_grid calculation
  2. Fixed the bug in which the cache key for the pdf method was the sum of the array values to something that makes much more sense in the case of array parameters
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 7, 2014

Thx @demianw. Will have a look asap. :)

@maurozucchelli

This comment has been minimized.

Contributor

maurozucchelli commented Feb 8, 2014

Ok I tested it and it looks good to me. Thank you very much @demianw for your help!

What do you think @Garyfallidis?

@mdesco

This comment has been minimized.

Contributor

mdesco commented Feb 8, 2014

Looks good to me. Thanks Dem.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Feb 10, 2014

Thank you for the enhancement Demian :) Merged!

Garyfallidis added a commit that referenced this pull request Feb 10, 2014

@Garyfallidis Garyfallidis merged commit 137186f into nipy:master Feb 10, 2014

1 check passed

default The Travis CI build passed
Details
@demianw

This comment has been minimized.

Contributor

demianw commented Feb 10, 2014

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment