New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FVTK small improvement: Arbitrary matplotlib colormaps can be used to color spherical functions #339

Merged
merged 2 commits into from Jun 3, 2014

Conversation

Projects
None yet
2 participants
@demianw
Contributor

demianw commented Mar 14, 2014

Small update to allow any matplotlib colormap to be used in the colouring of spherical functions

@@ -32,6 +32,8 @@
vtk, have_vtk, setup_module = optional_package('vtk')
colors, have_vtk_colors, _ = optional_package('vtk.util.colors')
import matplotlib

This comment has been minimized.

@arokem

arokem Mar 14, 2014

Member

We're trying to keep matplotlib as an optional dependency for now. Take a look at the import here:

https://github.com/nipy/dipy/blob/master/dipy/viz/projections.py#L12

This comment has been minimized.

@demianw

demianw Mar 14, 2014

Contributor

Ah! I can fix that and adapt the code

This comment has been minimized.

@arokem

arokem Mar 14, 2014

Member

Yep - as easy as "copy-paste" :-)

On Fri, Mar 14, 2014 at 10:54 AM, Demian Wassermann <
notifications@github.com> wrote:

In dipy/viz/fvtk.py:

@@ -32,6 +32,8 @@
vtk, have_vtk, setup_module = optional_package('vtk')
colors, have_vtk_colors, _ = optional_package('vtk.util.colors')

+import matplotlib

Ah! I can fix that and adapt the code


Reply to this email directly or view it on GitHubhttps://github.com//pull/339/files#r10619060
.

@arokem

This comment has been minimized.

Member

arokem commented Mar 25, 2014

Hey @demianw - just checking in with you about this one. Have you had a chance to do that copy-paste operation?

@demianw

This comment has been minimized.

Contributor

demianw commented Mar 25, 2014

Hey @arokem , thanks for the follow-up. I'm abroad until next week. I will perform the modifications next week

@arokem

This comment has been minimized.

Member

arokem commented Mar 25, 2014

OK - just wanted to make sure it doesn't slip through the cracks. Thanks!

On Tue, Mar 25, 2014 at 1:03 PM, Demian Wassermann <notifications@github.com

wrote:

Hey @arokem https://github.com/arokem , thanks for the follow-up. I'm
abroad until next week. I will perform the modifications next week


Reply to this email directly or view it on GitHubhttps://github.com//pull/339#issuecomment-38613374
.

@arokem arokem merged commit 137ce8c into nipy:master Jun 3, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@arokem

This comment has been minimized.

Member

arokem commented Jun 3, 2014

Sorry for the time that took. I just merged that manually (after checking locally on my machine).

@demianw

This comment has been minimized.

Contributor

demianw commented Jun 4, 2014

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment