New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Ignore this PR! #343

Closed
wants to merge 108 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@omarocegueda
Contributor

omarocegueda commented Apr 5, 2014

No description provided.

omarocegueda and others added some commits May 1, 2013

Renamed ornlm_module.pyx to ornlm.pyx (there was a naming conflict wi…
…th the c++ source code, but it was already eliminated)
Started changing coding style in files and moving files in their corr…
…ect position according to the dipy guidelines

omarocegueda added some commits Mar 14, 2014

Simplified the code of warping and vector field composition. Fixed em…
…barrasing mistake composing displacement fields with pre-multiplying affine matrices: the full set of experiments must be re-run.

@omarocegueda omarocegueda changed the title from Double prec to Please Ignore this PR! Apr 5, 2014

reconst_shore_metrics.py
streamline_tools.py
denoise_nlmeans.py

This comment has been minimized.

@samuelstjean

samuelstjean Apr 5, 2014

Contributor

Some old stuff seems to have snuck with this PR, maybe you could break it down in smaller, independent PR, this is kinda big to read as it currently is.

@arokem

This comment has been minimized.

Member

arokem commented Apr 5, 2014

Oh, you tease!

On Sat, Apr 5, 2014 at 1:37 PM, Omar Ocegueda notifications@github.comwrote:

Closed #343 #343.


Reply to this email directly or view it on GitHubhttps://github.com//pull/343
.

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Apr 5, 2014

Sorry, I sent this PR accidentally =(
-Omar.

On Sat, Apr 5, 2014 at 4:38 PM, Ariel Rokem notifications@github.comwrote:

Oh, you tease!

On Sat, Apr 5, 2014 at 1:37 PM, Omar Ocegueda notifications@github.comwrote:

Closed #343 #343.

Reply to this email directly or view it on GitHub<
https://github.com/nipy/dipy/pull/343>
.

Reply to this email directly or view it on GitHubhttps://github.com//pull/343#issuecomment-39650149
.

"Cada quien es dueño de lo que calla y esclavo de lo que dice"
-Proverbio chino.
"We all are owners of what we keep silent and slaves of what we say"
-Chinese proverb.

http://www.cimat.mx/~omar

@arokem

This comment has been minimized.

Member

arokem commented Apr 5, 2014

No worries. Looking forward to the storm, when it arrives. Looks amazing.

On Sat, Apr 5, 2014 at 1:47 PM, Omar Ocegueda notifications@github.comwrote:

Sorry, I sent this PR accidentally =(
-Omar.

On Sat, Apr 5, 2014 at 4:38 PM, Ariel Rokem notifications@github.comwrote:

Oh, you tease!

On Sat, Apr 5, 2014 at 1:37 PM, Omar Ocegueda notifications@github.comwrote:

Closed #343 #343.

Reply to this email directly or view it on GitHub<
https://github.com/nipy/dipy/pull/343>
.

Reply to this email directly or view it on GitHub<
https://github.com/nipy/dipy/pull/343#issuecomment-39650149>
.

"Cada quien es dueño de lo que calla y esclavo de lo que dice"
-Proverbio chino.
"We all are owners of what we keep silent and slaves of what we say"
-Chinese proverb.

http://www.cimat.mx/~omar


Reply to this email directly or view it on GitHubhttps://github.com//pull/343#issuecomment-39650372
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment