New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the mode param for border management. #364

Merged
merged 2 commits into from May 26, 2014

Conversation

Projects
None yet
4 participants
@matthieudumont
Contributor

matthieudumont commented May 12, 2014

I added the possibility to specify the mode parameter to scipy's affine_transform to have more control over border management.

The only real code change is the addition of the mode param to the resample method and the passing of this mode to the two affine_transform calls. All the other changes are some pep8ifications while I was there.

mode : string ('constant', 'nearest', 'reflect' or 'wrap')
Points outside the boundaries of the input are filled according
to the given mode.

This comment has been minimized.

@stefanv

stefanv May 12, 2014

Contributor

If you add mode, I guess one should also add cval.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented May 12, 2014

Can you also add some tests to check that the new parameter(s) get applied?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented May 26, 2014

No, I will write the test for this function. This is some of my very old cold for which I didn't create a test. This is my responsibility. Thank you @matthieudumont for the fix.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented May 26, 2014

I will add also an issue so that I don't forget about this. Thx!

Garyfallidis added a commit that referenced this pull request May 26, 2014

Merge pull request #364 from matthieudumont/resample_border_mode
Add the mode param for border management.

@Garyfallidis Garyfallidis merged commit 8ebe5ef into nipy:master May 26, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@matthieudumont matthieudumont deleted the matthieudumont:resample_border_mode branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment