New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: don't use -fopenmp flag if it doesn't work #371

Merged
merged 1 commit into from Jun 1, 2014

Conversation

Projects
None yet
5 participants
@matthew-brett
Member

matthew-brett commented Jun 1, 2014

Fairly general refactor of setup to try candidate compile flags, and remove
flags from compile that cause a compile or link error.

MinRK's pyzmq zeromq build machinery was the main inspiration for this way of
doing it.

RF: don't use -fopenmp flag if it doesn't work
Fairly general refactor of setup to try candidate compile flags, and
remove flags from compile that cause a compile or link error.

MinRK's pyzmq zeromq build machinery was the main inspiration for this
way of doing it.
@mdesco

This comment has been minimized.

Contributor

mdesco commented Jun 1, 2014

This is cool. Works well for me.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 1, 2014

Worked in Win 7 64 bit too. Thx!

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Jun 1, 2014

Nice! =) Works in Windows 8.1, with and without TDM-GCC: removed TDM-GCC
from the path and verified that "Flag -fopenmp omitted because of compile
or link error" was reported.
Thanks!

On Sat, May 31, 2014 at 11:17 PM, Matthew Brett notifications@github.com
wrote:

Fairly general refactor of setup to try candidate compile flags, and remove
flags from compile that cause a compile or link error.

MinRK's pyzmq zeromq build machinery was the main inspiration for this way
of

doing it.

You can merge this Pull Request by running

git pull https://github.com/matthew-brett/dipy check-openmp-flags

Or view, comment on, or merge it at:

#371
Commit Summary

  • RF: don't use -fopenmp flag if it doesn't work

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#371.

"Cada quien es dueño de lo que calla y esclavo de lo que dice"
-Proverbio chino.
"We all are owners of what we keep silent and slaves of what we say"
-Chinese proverb.

http://www.cimat.mx/~omar

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 1, 2014

Great! Thx Matthew and all for the feedback!

Garyfallidis added a commit that referenced this pull request Jun 1, 2014

Merge pull request #371 from matthew-brett/check-openmp-flags
RF: don't use -fopenmp flag if it doesn't work

@Garyfallidis Garyfallidis merged commit 622a926 into nipy:master Jun 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jchoude

This comment has been minimized.

Contributor

jchoude commented Jun 2, 2014

Very nice! Thanks @matthew-brett for this! Exactly what I had in mind, just didn't have the knowledge on how to do it properly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment