New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #346 from omarocegueda/syn_registration" #406

Merged
merged 1 commit into from Aug 6, 2014

Conversation

Projects
None yet
3 participants
@matthew-brett
Member

matthew-brett commented Aug 4, 2014

This reverts commit e63c178, reversing
changes made to c273fe5.

We decided to back off these commits until we had checked the code coverage of
the Cython modules, or timed out doing that.

Discussion here:

#34

Revert "Merge pull request #346 from omarocegueda/syn_registration"
This reverts commit e63c178, reversing
changes made to c273fe5.

We decided to back off these commits until we had checked the code
coverage of the Cython modules, or timed out doing that.

Discussion here:

#34

Garyfallidis added a commit that referenced this pull request Aug 6, 2014

Merge pull request #406 from matthew-brett/sorry-to-omar-for-now
Revert "Merge pull request #346 from omarocegueda/syn_registration"

@Garyfallidis Garyfallidis merged commit f53a8c8 into nipy:master Aug 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Aug 6, 2014

Hi @omarocegueda we reverted your PR. Update your syn_registration branch with your cleanups and tests and make a new PR. Hopefully, that should go in smoothly. Let us know how it goes.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Aug 6, 2014

Sorry Omar - I hope we won't be long - we just need to check the Cython
code coverage...​

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Aug 7, 2014

No worries! =) it's great that you guys keep pushing quality even further
in Dipy!

On Wed, Aug 6, 2014 at 11:00 AM, Matthew Brett notifications@github.com
wrote:

Sorry Omar - I hope we won't be long - we just need to check the Cython
code coverage...​


Reply to this email directly or view it on GitHub
#406 (comment).

"Cada quien es dueño de lo que calla y esclavo de lo que dice"
-Proverbio chino.
"We all are owners of what we keep silent and slaves of what we say"
-Chinese proverb.

http://www.cimat.mx/~omar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment