New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename README.txt to README.rst #420

Merged
merged 3 commits into from Sep 19, 2014

Conversation

Projects
None yet
3 participants
@samuelstjean
Contributor

samuelstjean commented Sep 18, 2014

Now we can have fancy markdown for free! That always tired me each time I went on github, and I can't find a reason why nobody bothered, so here it is, fancified readme in 3 seconds for free.

@arokem

This comment has been minimized.

Member

arokem commented Sep 18, 2014

Without looking too closely - there are a few places where README.txt appears (in particular in tools/osxbuild.py). Could you please check what side-effects will this have in building the OSX binaries?

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Sep 18, 2014

Shouldn't the build bot complain in that case?

@arokem

This comment has been minimized.

Member

arokem commented Sep 18, 2014

It would - did you run this PR through the build-bot?

On Thu, Sep 18, 2014 at 11:33 AM, Samuel St-Jean notifications@github.com
wrote:

Shouldn't the build bot complain in that case?


Reply to this email directly or view it on GitHub
#420 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Sep 18, 2014

I think Sam means travis here. Travis is a linux bot.

On Thu, Sep 18, 2014 at 2:54 PM, Ariel Rokem notifications@github.com
wrote:

It would - did you run this PR through the build-bot?

On Thu, Sep 18, 2014 at 11:33 AM, Samuel St-Jean notifications@github.com

wrote:

Shouldn't the build bot complain in that case?


Reply to this email directly or view it on GitHub
#420 (comment).


Reply to this email directly or view it on GitHub
#420 (comment).

@arokem

This comment has been minimized.

Member

arokem commented Sep 18, 2014

Gotcha. Sure enough, Travis would not complain about OSX-related issues.

On Thu, Sep 18, 2014 at 11:58 AM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

I think Sam means travis here. Travis is a linux bot.

On Thu, Sep 18, 2014 at 2:54 PM, Ariel Rokem notifications@github.com
wrote:

It would - did you run this PR through the build-bot?

On Thu, Sep 18, 2014 at 11:33 AM, Samuel St-Jean <
notifications@github.com>

wrote:

Shouldn't the build bot complain in that case?


Reply to this email directly or view it on GitHub
#420 (comment).


Reply to this email directly or view it on GitHub
#420 (comment).


Reply to this email directly or view it on GitHub
#420 (comment).

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Sep 18, 2014

Oh, I though Travis was testing multiple platform, anyway I'm currently grepping the whole of dipy's root to find them, should takes a while though.

@arokem

This comment has been minimized.

Member

arokem commented Sep 18, 2014

OK - thanks for taking a look. It's such a small change, that if it has any
downstream consequences, we might not understand where/what happened.

On Thu, Sep 18, 2014 at 12:04 PM, Samuel St-Jean notifications@github.com
wrote:

Oh, I though Travis was testing multiple platform, anyway I'm currently
grepping the whole of dipy's root to find them, should takes a while though.


Reply to this email directly or view it on GitHub
#420 (comment).

samuelstjean added some commits Sep 18, 2014

@samuelstjean

This comment has been minimized.

Contributor

samuelstjean commented Sep 18, 2014

Turns out git grep -n is super fast compared to the regular grep, for future reference.

arokem added a commit that referenced this pull request Sep 19, 2014

Merge pull request #420 from samuelstjean/master
Rename README.txt to README.rst

@arokem arokem merged commit 94ec5bf into nipy:master Sep 19, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment