New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: relax threshold for failing test + cleanup #456

Merged
merged 2 commits into from Nov 1, 2014

Conversation

Projects
None yet
3 participants
@matthew-brett
Member

matthew-brett commented Oct 31, 2014

Relax threshold for failing test as suggested by Omar.

Closes gh-455.

Clean up some PEP8 formatting.

matthew-brett added some commits Oct 31, 2014

TST: relax test for streamline length
Use almost equal test for alternative streamline length test.
RF: some PEP8 cleanup of test module
Long lines wrapped.
Some empty lines removed.
Specific import of functions to be tested.
@arokem

This comment has been minimized.

Member

arokem commented Oct 31, 2014

Hey @omarocegueda - do you have merge rights on nipy/dipy? Would you mind giving this a review? I'm only picking on you because you seem responsive ATM :-)

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Oct 31, 2014

Actually this one's fairly easy to review as long as you look at the commits separately rather than 'files changed'. The first commit is just relaxing the threshold. The second is just PEP8 stuff.

Any of us can merge as long as one of us does a review.

@arokem

This comment has been minimized.

Member

arokem commented Oct 31, 2014

Oh - I'm just trying to expand the number of people who feel free
(obliged?) to jump in on these ('simple') things. There seem to be just a
few of those...

On Fri, Oct 31, 2014 at 2:39 PM, Matthew Brett notifications@github.com
wrote:

Actually this one's fairly easy to review as long as you look at the
commits separately rather than 'files changed'. The first commit is just
relaxing the threshold. The second is just PEP8 stuff.

Any of us can merge as long as one of us does a review.


Reply to this email directly or view it on GitHub
#456 (comment).

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Oct 31, 2014

Sure!, it looks good to me. I also confirm that the tests pass on my side. Thanks =)

@arokem

This comment has been minimized.

Member

arokem commented Nov 1, 2014

Feel free to hit the green button to merge this...

On Fri, Oct 31, 2014 at 3:03 PM, Omar Ocegueda notifications@github.com
wrote:

Sure!, it looks good to me. I also confirm that the tests pass on my side.
Thanks =)


Reply to this email directly or view it on GitHub
#456 (comment).

matthew-brett added a commit that referenced this pull request Nov 1, 2014

Merge pull request #456 from matthew-brett/approx-streamline-tests
MRG: relax threshold for failing test + cleanup

Relax threshold for failing test as suggested by Omar.

Closes gh-455.

Clean up some PEP8 formatting.

@matthew-brett matthew-brett merged commit b7af2b6 into nipy:master Nov 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@matthew-brett matthew-brett deleted the matthew-brett:approx-streamline-tests branch Nov 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment