New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: docstring fixes in dipy/align/crosscorr.pyx #458

Merged
merged 2 commits into from Nov 3, 2014

Conversation

Projects
None yet
5 participants
@grlee77
Contributor

grlee77 commented Nov 3, 2014

I am excited to see the recent addition of image alignment to dipy. This is very nice!

This small pull request fixes an inconsistency between the docstrings and the implementation.

@grlee77

This comment has been minimized.

Contributor

grlee77 commented Nov 3, 2014

Changed year and added journal name of one of the references to match the pubmed listing:
http://www.ncbi.nlm.nih.gov/pubmed/17659998

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 3, 2014

Thank you @grlee, your feedback is much welcome. I will let first @omarocegueda to review your PR and then merge it.

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Nov 3, 2014

Thank you for your help @grlee77 ! the fix looks good to me @Garyfallidis
Thanks! =)

arokem added a commit that referenced this pull request Nov 3, 2014

Merge pull request #458 from grlee77/docfix
DOC:  docstring fixes in dipy/align/crosscorr.pyx

@arokem arokem merged commit c3d5fee into nipy:master Nov 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Nov 3, 2014

Time to give Omar merge rights?

@arokem

This comment has been minimized.

Member

arokem commented Nov 3, 2014

+1

On Mon, Nov 3, 2014 at 11:07 AM, Matthew Brett notifications@github.com
wrote:

Time to give Omar merge rights?


Reply to this email directly or view it on GitHub
#458 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment