New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix writing history to file in Python 3 #462

Merged
merged 1 commit into from Nov 13, 2014

Conversation

Projects
None yet
2 participants
@matthew-brett
Member

matthew-brett commented Nov 13, 2014

Need to open file in binary mode to save text, strangely.

See:
http://nipy.bic.berkeley.edu/builders/dipy-py3.3/builds/227/steps/shell_8/logs/stdio
for error.

BF: fix writing history to file in Python 3
Need to open file in binary mode to save text, strangely.
@arokem

This comment has been minimized.

Member

arokem commented Nov 13, 2014

Does the text in the file come out reasonable when you do this?

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Nov 13, 2014

Yes - on Python 2 and 3. The code is just writing the parameters (a vector of numbers) at each step.

arokem added a commit that referenced this pull request Nov 13, 2014

Merge pull request #462 from matthew-brett/fix-for-py3-streams
BF: fix writing history to file in Python 3

@arokem arokem merged commit 74b3641 into nipy:master Nov 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@matthew-brett matthew-brett deleted the matthew-brett:fix-for-py3-streams branch Nov 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment