New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SLR to allow for series of registrations #480

Merged
merged 4 commits into from Nov 25, 2014

Conversation

Projects
None yet
2 participants
@Garyfallidis
Member

Garyfallidis commented Nov 24, 2014

For example first rigid, then similarity then affine etc. As it is possible in ANTs.

mat : array
Transformation (4, 4) matrix to start the registration. ``mat``
is applied to moving. Default value None which means that initial
transformation will be generated by shiftin the centers of moving

This comment has been minimized.

@arokem

arokem Nov 24, 2014

Member

Typo: "shiftin" => "shifting"

@arokem

This comment has been minimized.

Member

arokem commented Nov 24, 2014

Apart from that typo, I have no comments on the contents of this PR. One suggestion is to improve the tests around here:

https://github.com/nipy/dipy/pull/480/files#diff-c66394c613960f7d56ba9ff5e2c1c1f3L431

By comparing what happens when the x0 input is a string (e.g. 'rigid') to the input is an array. They should be identical, and then we wouldn't just be doing smoke-testing there. Thoughts?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 25, 2014

Hi @arokem. I don't understand what you mean with your last comment. This tests checks that the argument is of the correct string or integer type and raises an error otherwise. What you like to add as a test? Can you be a bit more clear?

@arokem

This comment has been minimized.

Member

arokem commented Nov 25, 2014

Something to make sure that:

StreamlineLinearRegistration(x0='rigid') == StreamlineLinearRegistration(x0=np.zeros(6))
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 25, 2014

Thx. Test added :)

arokem added a commit that referenced this pull request Nov 25, 2014

Merge pull request #480 from Garyfallidis/enhance_slr_multi
Enhance SLR to allow for series of registrations

@arokem arokem merged commit 637c177 into nipy:master Nov 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment