New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - make examples was confusing files with similar names, fixed #481

Merged
merged 1 commit into from Nov 25, 2014

Conversation

Projects
None yet
2 participants
@MrBago
Contributor

MrBago commented Nov 25, 2014

I tried to make the parsing of the "valid_examples.txt" file a little smoother.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 25, 2014

Hi @MrBago, can you explain a bit more what you tried to fix here? What do you mean with similar names?

@MrBago

This comment has been minimized.

Contributor

MrBago commented Nov 25, 2014

Specifically if you remove quick_start.py from valid_examples.txt but leave tracking_quick_start.py both examples still get run. The only way to not run quick_start.py (without this fix) is to comment out or remove both lines from valid_examples.txt.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Nov 25, 2014

Cool, thx for the clarification.

Garyfallidis added a commit that referenced this pull request Nov 25, 2014

Merge pull request #481 from MrBago/bf_make_examples
BF - make examples was confusing files with similar names, fixed

@Garyfallidis Garyfallidis merged commit 902783f into nipy:master Nov 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment