New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - older C compliers do not have round in math.h, uisng dpy_math instead #493

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@MrBago
Contributor

MrBago commented Dec 9, 2014

No description provided.

@MrBago MrBago force-pushed the MrBago:bf_round_issue branch from 022b1a8 to deed0e1 Dec 9, 2014

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Dec 9, 2014

It's weird, apparently it's still failing in win32. This is what I get using 'try_branch' with this PR on buildbot dipy-py2.7-win32:
http://nipy.bic.berkeley.edu/builders/dipy-py2.7-win32/builds/124/steps/shell_5/logs/stdio

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Dec 9, 2014

should we implement our own round using floor?:
http://stackoverflow.com/questions/485525/round-for-float-in-c

@MrBago

This comment has been minimized.

Contributor

MrBago commented Dec 9, 2014

I had a feeling this might happen. I think I'm just going to write my own
round function, but I'll wait a few days until in case someone knows a
better solution.

Bago
On Dec 8, 2014 6:41 PM, "Omar Ocegueda" notifications@github.com wrote:

It's weird, apparently it's still failing in win32. This is what I get
using 'try_branch' with this PR on buildbot dipy-py2.7-win32:

http://nipy.bic.berkeley.edu/builders/dipy-py2.7-win32/builds/124/steps/shell_5/logs/stdio


Reply to this email directly or view it on GitHub
#493 (comment).

@omarocegueda omarocegueda referenced this pull request Dec 9, 2014

Merged

Fix round #494

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Dec 9, 2014

I think we can use the same idea as for dpy_log2 by borrowing code from numpy:
https://github.com/nipy/dipy/blob/master/src/dpy_math.h#L15

Sorry, I don't know what's the procedure to help with a PR from someone else (I couldn't push to your branch), so I created a new PR:
#494

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented Dec 14, 2014

Fixed with #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment