New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sphere for ODF reconstruction #497

Merged
merged 4 commits into from Dec 18, 2014

Conversation

Projects
None yet
4 participants
@mpaquette
Contributor

mpaquette commented Dec 11, 2014

Added a new sphere (repulsion724) created from symmetric724 by applying some repulsion iteration (5000).
This sphere is antipodally symmetric and much more evenly distributed, especially at the z=0 equator (see attached image).

Closest points in symmetric724 are 3.70 degrees apart, average distance (to closest neighbor) is 7.08 degrees.
Closest points in repulsion724 are 7.29 degrees apart, average distance (to closest neighbor) is 7.76 degrees.

sphere_symmetric724_equator_uneveness

@arokem

This comment has been minimized.

Member

arokem commented Dec 11, 2014

Might be good to change at least one of the tests that currently uses symmetric724 to use repulsion724 instead, just so this code path gets executed regularly.

For example, here:

https://github.com/nipy/dipy/blob/master/dipy/reconst/tests/test_peaks.py#L525

@mdesco

This comment has been minimized.

Contributor

mdesco commented Dec 11, 2014

@mpaquette, is it also possible to add 1 or 2 smaller spheres when we need
fast peak extraction computation. A 100 points sphere would be nice to have.

@arokem

This comment has been minimized.

Member

arokem commented Dec 11, 2014

I am not sure how many of these we should add. This computation doesn't
take long at all:

https://github.com/nipy/dipy/blob/master/doc/examples/gradients_spheres.py#L32

On Thu, Dec 11, 2014 at 6:34 AM, Maxime Descoteaux <notifications@github.com

wrote:

@mpaquette, is it also possible to add 1 or 2 smaller spheres when we need
fast peak extraction computation. A 100 points sphere would be nice to
have.

Max

Maxime Descoteaux, PhD
Professor
Sherbrooke Connectivity Imaging Laboratory (SCIL)
Centre de Recherche CHUS
Computer Science department
Sherbrooke University
2500 Boul. Université
Sherbrooke, Québec
J1K 2R1, Canada
phone: +1 819 821-8000 x66129
fax: +1 819 821-8200
http://scil.dinf.usherbrooke.ca

Scientific director
Visualization and Image Analysis Plateform (PAVI)
http://pavi.dinf.usherbrooke.ca/

On Wed, Dec 10, 2014 at 11:19 PM, Ariel Rokem notifications@github.com
wrote:

Might be good to change at least one of the tests that currently uses
symmetric724 to use repulsion724 instead, just so this code path gets
executed regularly.

For example, here:

https://github.com/nipy/dipy/blob/master/dipy/reconst/tests/test_peaks.py#L525


Reply to this email directly or view it on GitHub
https://github.com/nipy/dipy/pull/497#issuecomment-66567162.[image:
Web
Bug from

https://github.com/notifications/beacon/ACEgB9Z6Ak7-S1fJ3s1VEs9nu5g76y8Nks5nWRLtgaJpZM4DG9F8.gif]


Reply to this email directly or view it on GitHub
#497 (comment).

@arokem

This comment has been minimized.

Member

arokem commented Dec 16, 2014

Hey @mpaquette - would you mind making a change to one of the tests for this PR? See my comment above - it's just a one line change. Actually, just a few characters!

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 18, 2014

Thx @mpaquette for the beautiful spheres!!

@arokem

This comment has been minimized.

Member

arokem commented Dec 18, 2014

Thanks for reminding me - I missed the recent commit. Merging...

arokem added a commit that referenced this pull request Dec 18, 2014

Merge pull request #497 from mpaquette/better_sphere724
New sphere for ODF reconstruction

@arokem arokem merged commit 93f06bc into nipy:master Dec 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 18, 2014

@arokem I had to restart one of the Travis buildbots which was timed out. We may see that happening again. Just restart this bot from the Travis interface if you see that happening again. GGT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment