New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility issues between vtk 5 and 6 #503

Merged
merged 2 commits into from Dec 13, 2014

Conversation

Projects
None yet
2 participants
@Garyfallidis
Member

Garyfallidis commented Dec 12, 2014

Some of the functions have changed in VTK 6. This should correct those problems.

@arokem

This comment has been minimized.

Member

arokem commented Dec 13, 2014

Looks good. Is there any way we could automatically test this with both versions of VTK? Presumably that would be a pain in the neck to do?

@arokem

This comment has been minimized.

Member

arokem commented Dec 13, 2014

Not changed in this PR, but I think that the variable version is not used anywhere:
https://github.com/Garyfallidis/dipy/blob/fix_rec_vtk6/dipy/viz/fvtk.py#L50

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 13, 2014

Yes, it is a bit of pain in the neck to do. But with the new version of fvtk (an upcoming PR) I will have some testing for issues like this. However, I have to say that vtk6 has many cool features and I am thinking of stopping supporting vtk5 in the near future. As vtk is an optional dependency it shouldn't create much trouble to dipy and it may save us from quite a bit of work for supporting both versions. Furthermore, we will will have to move to a vtk6+ version soon when vtk will start supporting python 3. The more I think of it the more I realize that vtk5 is nearly dead for us.... But hey let's discuss about this at a later time.

@arokem

This comment has been minimized.

Member

arokem commented Dec 13, 2014

Is vtk6 going to support both 2 and 3? What do I have to do to install vtk6
(on mac)? Anaconda doesn't seem to have that.

I suggest that we do all this in a future release, around February. We need
to start closing this thing.

On Sat, Dec 13, 2014 at 12:38 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

Yes, it is a bit of pain in the neck to do. But with the new version of
fvtk (an upcoming PR) I will have some testing for issues like this.
However, I have to say that vtk6 has many cool features and I am thinking
of stopping supporting vtk5 in the near future. As vtk is an optional
dependency it shouldn't create much trouble to dipy and it may save us from
quite a bit of work for supporting both versions. Furthermore, we will will
have to move to a vtk6+ version soon when vtk will start supporting python
3. The more I think of it the more I realize that vtk5 is nearly dead for
us.... But hey let's discuss about this at a later time.


Reply to this email directly or view it on GitHub
#503 (comment).

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 13, 2014

Yeah let's discuss this later. I will definitely investigate portability issues with vtk6 before making the switch. Can you merge this small fix? Thx in advance.

arokem added a commit that referenced this pull request Dec 13, 2014

Merge pull request #503 from Garyfallidis/fix_rec_vtk6
Fixed compatibility issues between vtk 5 and 6

@arokem arokem merged commit 62aae7b into nipy:master Dec 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment