New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF + TST: Reinstated eig_from_lo_tri #513

Merged
merged 1 commit into from Dec 25, 2014

Conversation

Projects
None yet
3 participants
@arokem
Member

arokem commented Dec 21, 2014

Maybe someone can tell me what the use-case is for this function? It used to be here as an input to the Tensor model, but that structure was changed long ago, so I am not sure what you would use this for... Anyway - it's back, by popular demand:

http://mail.scipy.org/pipermail/nipy-devel/2014-December/010734.html

BF + TST: Reinstated eig_from_lo_tri
Now, with testing!
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 23, 2014

@MrBago and the rest what do you think? Should we put this function back?

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Dec 24, 2014

@arokem if you think that this function is not needed we don't need to put it back. We just need to explain how you can replicate the behaviour using other existing functions.

@MrBago

This comment has been minimized.

Contributor

MrBago commented Dec 25, 2014

This looks good to me @arokem. The best way to know if something is useful is if someone is using it. I would also expect that after our API change this function would not be needed anymore, but it seems someone is in fact using it and I think we should try and avoid breaking others people code whenever we can. I say we put it back.

MrBago added a commit that referenced this pull request Dec 25, 2014

Merge pull request #513 from arokem/eig_from_lo_tri
BF + TST: Reinstated eig_from_lo_tri

@MrBago MrBago merged commit 871108e into nipy:master Dec 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment