Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
MRG: some Cython refactorings #533
Hi guys, I don't have further comments on this PR (I was a bit concern about performance but I even observed a small speed up =) ), I think it is ok to be merged (the documentation suggestion is not so important). I just have a question: I used this PR as "guidelines" to refactor another .pyx, how are we going to proceed here? are we going to make several PRs doing this kind of refactorings or should we make PRs on top of this one and merge until we have finish refactoring everything? (if we are going to do several PRs, we should merge this one and keep going, no?)
Omar - I suggest that we merge this one (if you are happy with my last doc edits) then submit more PRs with refactoring. I actually have some more refactorings on top of these, but I wanted to keep this PR stable so y'all could review it and sign off without it getting confusing with more changes on top.