# DOC + PEP8: Mostly just line-wrapping. #594

Merged
merged 2 commits into from Mar 18, 2015

## Conversation

Projects
None yet
2 participants
Member

### arokem commented Mar 15, 2015

 And a few small edits on the csd example.
``` DOC + PEP8: Mostly just line-wrapping. ```
`A few small edits on the csd example.`
``` 1a590bb ```

### Garyfallidis reviewed Mar 15, 2015

 We can double check that we have a good response function by visualizing the response's function's ODF. Here is how: We can double-check that we have a good response function by visualizing the response's function's ODF. Here is how you would do that:

#### Garyfallidis Mar 15, 2015

Member

typo: response function's
And I would remove all from Here ...
I think it is redundant

Member

Done

### Garyfallidis reviewed Mar 15, 2015

 diffusion tensor (FA and first eigenvector), which has low accuracy at high b-value. Alternatively, one can calibrate the response function directly from the data according to [Tax2014]_. Depending on the dataset, FA threshold may not be the best way to divine the

Member

divine?

#### arokem Mar 16, 2015

Member

From the Oxford English Dictionary:

"Divine, v. : 2. To make out by sagacity, intuition, or fortunate
conjecture (that is, in some other way than by actual information); to
conjecture, guess."

On Sun, Mar 15, 2015 at 4:49 PM, Eleftherios Garyfallidis <

In doc/examples/reconst_csd.py
#594 (comment):

@@ -98,18 +101,17 @@
fvtk.rm(ren, response_actor)

"""
-However, using an FA threshold is not a very robust method. It is dependent on
-the dataset (non-informed used subjectivity), and still depends on the
-diffusion tensor (FA and first eigenvector), which has low accuracy at high
-b-value. Alternatively, one can calibrate the response function directly from
-the data according to [Tax2014]_.
+Depending on the dataset, FA threshold may not be the best way to divine the

divine?

Reply to this email directly or view it on GitHub
https://github.com/nipy/dipy/pull/594/files#r26454168.

#### Garyfallidis Mar 16, 2015

Member

Keep it simple. This use of the word is very rare afaik.
Even guess is too vague here.

I would say: find the best possible response function.

#### arokem Mar 16, 2015

Member

done

``` DOC: Correct typos and simplify. ```
``` e561e7d ```

### Garyfallidis added a commit that referenced this pull request Mar 18, 2015

``` Merge pull request #594 from arokem/csd-fixes ```
`DOC + PEP8: Mostly just line-wrapping.`
``` d90425e ```

### Garyfallidis merged commit `d90425e` into nipy:master Mar 18, 2015 1 check passed

#### 1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details