New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC + PEP8: Mostly just line-wrapping. #594

Merged
merged 2 commits into from Mar 18, 2015

Conversation

Projects
None yet
2 participants
@arokem
Member

arokem commented Mar 15, 2015

And a few small edits on the csd example.

DOC + PEP8: Mostly just line-wrapping.
A few small edits on the csd example.
We can double check that we have a good response function by visualizing the
response's function's ODF. Here is how:
We can double-check that we have a good response function by visualizing the
response's function's ODF. Here is how you would do that:

This comment has been minimized.

@Garyfallidis

Garyfallidis Mar 15, 2015

Member

typo: response function's
And I would remove all from Here ...
I think it is redundant

This comment has been minimized.

@arokem
diffusion tensor (FA and first eigenvector), which has low accuracy at high
b-value. Alternatively, one can calibrate the response function directly from
the data according to [Tax2014]_.
Depending on the dataset, FA threshold may not be the best way to divine the

This comment has been minimized.

@Garyfallidis

This comment has been minimized.

@arokem

arokem Mar 16, 2015

Member

From the Oxford English Dictionary:

"Divine, v. : 2. To make out by sagacity, intuition, or fortunate
conjecture (that is, in some other way than by actual information); to
conjecture, guess."

On Sun, Mar 15, 2015 at 4:49 PM, Eleftherios Garyfallidis <
notifications@github.com> wrote:

In doc/examples/reconst_csd.py
#594 (comment):

@@ -98,18 +101,17 @@
fvtk.rm(ren, response_actor)

"""
-However, using an FA threshold is not a very robust method. It is dependent on
-the dataset (non-informed used subjectivity), and still depends on the
-diffusion tensor (FA and first eigenvector), which has low accuracy at high
-b-value. Alternatively, one can calibrate the response function directly from
-the data according to [Tax2014]_.
+Depending on the dataset, FA threshold may not be the best way to divine the

divine?


Reply to this email directly or view it on GitHub
https://github.com/nipy/dipy/pull/594/files#r26454168.

This comment has been minimized.

@Garyfallidis

Garyfallidis Mar 16, 2015

Member

Keep it simple. This use of the word is very rare afaik.
Even guess is too vague here.

I would say: find the best possible response function.
Your call!

This comment has been minimized.

@arokem

Garyfallidis added a commit that referenced this pull request Mar 18, 2015

Merge pull request #594 from arokem/csd-fixes
DOC + PEP8: Mostly just line-wrapping.

@Garyfallidis Garyfallidis merged commit d90425e into nipy:master Mar 18, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment