New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF - no import of TissueTypes #633

Merged
merged 1 commit into from Apr 29, 2015

Conversation

Projects
None yet
3 participants
@MrBago
Contributor

MrBago commented Apr 23, 2015

TissueTypes was in __all__ but it was never imported.

@arokem

This comment has been minimized.

Member

arokem commented Apr 25, 2015

Thanks for noticing this. Is it ever used in this context? That is, why did you decide to import it, rather than removing it from __all__?

@MrBago

This comment has been minimized.

Contributor

MrBago commented Apr 28, 2015

I assumed that whoever added it to all wanted it there, but If none
objects I'm just as happy removing it.

Bago

On Fri, Apr 24, 2015 at 8:03 PM, Ariel Rokem notifications@github.com
wrote:

Thanks for noticing this. Is it ever used in this context? That is, why
did you decide to import it, rather than removing it from all?


Reply to this email directly or view it on GitHub
#633 (comment).

@arokem

This comment has been minimized.

Member

arokem commented Apr 28, 2015

Maybe @gabknight knows which way we want it. He added in TissueType here:
759859d
and it seems that there was some intention behind it, considering that it
was in the commit message. Hey @gabknight - what do you think we should do
here?

On Mon, Apr 27, 2015 at 5:10 PM, Bago Amirbekian notifications@github.com
wrote:

I assumed that whoever added it to all wanted it there, but If none
objects I'm just as happy removing it.

Bago

On Fri, Apr 24, 2015 at 8:03 PM, Ariel Rokem notifications@github.com
wrote:

Thanks for noticing this. Is it ever used in this context? That is, why
did you decide to import it, rather than removing it from all?


Reply to this email directly or view it on GitHub
#633 (comment).


Reply to this email directly or view it on GitHub
#633 (comment).

@gabknight

This comment has been minimized.

Contributor

gabknight commented Apr 28, 2015

'TissueType' can be removed from all, there is no need for it. Thanks!

@arokem

This comment has been minimized.

Member

arokem commented Apr 28, 2015

Thank you for clarifying!

On Tue, Apr 28, 2015 at 9:17 AM, Gabriel Girard notifications@github.com
wrote:

'TissueType' can be removed from all, there is no need for it. Thanks!


Reply to this email directly or view it on GitHub
#633 (comment).

@MrBago MrBago force-pushed the MrBago:bf_add_import branch from a0eefda to 4e78427 Apr 28, 2015

@MrBago

This comment has been minimized.

Contributor

MrBago commented Apr 28, 2015

K, I removed it from all.

@MrBago MrBago force-pushed the MrBago:bf_add_import branch from 4e78427 to e265aa3 Apr 28, 2015

@arokem

This comment has been minimized.

Member

arokem commented Apr 28, 2015

Cool. I don't expect any issues here, but I'll wait for Travis and then
commit.

Thanks!

On Tue, Apr 28, 2015 at 3:42 PM, Bago Amirbekian notifications@github.com
wrote:

K, I removed it from all.


Reply to this email directly or view it on GitHub
#633 (comment).

arokem added a commit that referenced this pull request Apr 29, 2015

Merge pull request #633 from MrBago/bf_add_import
BF - no import of TissueTypes

@arokem arokem merged commit 15eb966 into nipy:master Apr 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment