New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error caused by inline functions #657

Merged
merged 1 commit into from May 26, 2015

Conversation

Projects
None yet
2 participants
@omarocegueda
Contributor

omarocegueda commented May 26, 2015

If inline functions are just declared in the pxd, cython attempts to declare inline pointers to them, which is invalid since variables cannot be declared inline. According to this:
http://docs.cython.org/src/tutorial/pxd_files.html
inline functions should be defined, not just declared in the pxd.
Unfortunately, right now I don't have access to the buildbots to try this, but in theory this should fix the issue.

@arokem

This comment has been minimized.

Member

arokem commented May 26, 2015

Yup. I can confirm that with this branch in place everything compiles just fine on my (Mac) laptop, and tests all pass (except for the one that should be taken care of once #612 lands).

@arokem

This comment has been minimized.

Member

arokem commented May 26, 2015

I am going to go ahead and merge this into master, since it's small and presumably fixes a current breakage. Let's see what the buildbots do with this.

arokem added a commit that referenced this pull request May 26, 2015

Merge pull request #657 from omarocegueda/fix_inline
Fix compilation error caused by inline functions

@arokem arokem merged commit 938920d into nipy:master May 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arokem arokem referenced this pull request May 26, 2015

Closed

Build-bot status #656

@omarocegueda

This comment has been minimized.

Contributor

omarocegueda commented May 27, 2015

Thanks Ariel! =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment