New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: If n_frames is larger than one use path-numbering. #659

Merged
merged 3 commits into from Jun 4, 2015

Conversation

Projects
None yet
2 participants
@arokem
Member

arokem commented Jun 3, 2015

Otherwise, each consecutive frame over-writes the previous one.

BF: If n_frames is larger than one use path-numbering.
Otherwise, each consecutive frame over-writes the previous one.
@stefanv

This comment has been minimized.

Contributor

stefanv commented Jun 4, 2015

Looks good! Want to also fix the spelling error in the path_numbering parameter description?

@arokem

This comment has been minimized.

Member

arokem commented Jun 4, 2015

Thanks for the feedback. Added another commit fixing up the docstring.

On Wed, Jun 3, 2015 at 5:31 PM, Stefan van der Walt <
notifications@github.com> wrote:

Looks good! Want to also fix the spelling error in the path_numering
parameter description?


Reply to this email directly or view it on GitHub
#659 (comment).

cam_view : None or sequence (3,), optional
camera view up
Camera view up. Default

This comment has been minimized.

@stefanv

stefanv Jun 4, 2015

Contributor

Default is

@stefanv

This comment has been minimized.

Contributor

stefanv commented Jun 4, 2015

Nice, you caught a lot of fixes! Just the default of cam_view, then I can merge for you.

@arokem

This comment has been minimized.

Member

arokem commented Jun 4, 2015

Yeah - it's whatever the default is when you start one of these devils.
Just removed the word 'default' instead.

On Wed, Jun 3, 2015 at 6:31 PM, Stefan van der Walt <
notifications@github.com> wrote:

Nice, you caught a lot of fixes! Just the default of cam_view, then I can
merge for you.


Reply to this email directly or view it on GitHub
#659 (comment).

@stefanv

This comment has been minimized.

Contributor

stefanv commented Jun 4, 2015

❤️ that commit message

stefanv added a commit that referenced this pull request Jun 4, 2015

Merge pull request #659 from arokem/path-numbering
BF: If n_frames is larger than one use path-numbering.

@stefanv stefanv merged commit ee9a93c into nipy:master Jun 4, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@arokem arokem deleted the arokem:path-numbering branch Jun 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment